Update program upgrade authority check to use PDA #313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
check_is_upgrade_authority_for_programwe make sure that the signer of the instruction is the upgrade authority of the program. To do this we use two accounts owned bybpf-upgradable-loader:program_account: this is the account with addressprogram_id. It contains the address ofprogramdata_accountprogramdata_account: this account contains the code of the program and the upgrade authority.Previously I would get the address of
programdata_accountfromprogram_account. However I realized that I can get the address without deserializingprogram_accountbecause it is a PDA with seedprogram_id.I am trying to get rid of bincode in
upg_permissions. This change will reduce the footprint of bincode because we no longer need to deserializeprogram_account