Sma3 #288
Sma3 #288
Conversation
jayantk
left a comment
jayantk
left a comment
There was a problem hiding this comment.
this looks very solid to me. Pretty much all of the comments are minor except the one about the true which i think should be false.
| impl PriceAccountWrapper { | ||
| pub fn initialize_time_machine(&mut self) -> Result<(), OracleError> { | ||
| // TO DO | ||
| #[cfg(test)] |
There was a problem hiding this comment.
maybe comment why this is cfg(test)? I presume you're doing some sort of feature flag thing to keep this code out of the real deployment?
There was a problem hiding this comment.
fwiw I think a better place for this flag would actually be around the code the resize account code + the code that calls add_price_to_time_machine.
This is fine for this PR though.
There was a problem hiding this comment.
Added some comments. We can definitely gate those two instructions, but there's a test in the python for resizing that would need to get scrapped (the python tests use the production version of the rust binary).
|
|
Sma base implementation. It only implements 30min prices (no confidence).
It is gated by
cfg(test)flags while in development.