Skip to content

Conversation

@guibescos
Copy link
Contributor

@guibescos guibescos commented Aug 29, 2022

Replaces CPubkey with Solana sdk's own Pubkey

@guibescos guibescos marked this pull request as ready for review August 29, 2022 20:59
tompntn
tompntn previously approved these changes Aug 30, 2022
Copy link
Contributor

@tompntn tompntn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting changes to block merging until we validate that the serialized bytes for CPubkey and Pubkey are exactly equivalent

@guibescos guibescos merged commit 9ef18a2 into main Aug 30, 2022
@guibescos guibescos deleted the pubkey branch August 30, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants