Create rust structs and replace bindgen structs #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guibescos
force-pushed
the
rust-structs-3
branch
from
750384f to
3c3c53b
Compare
guibescos
commented
Aug 24, 2022
|
|
||
| #[repr(C)] | ||
| #[derive(Copy, Clone)] | ||
| pub union CPubkey { |
Contributor
Author
There was a problem hiding this comment.
Both fields are currently used in the code. I feel like we can get to a safe derivation if we :
- Replace CPubkey by the solana sdk Pubkey
- Update functions to only use
k1_ork8_.
Let's do it in a future PR.
Contributor
There was a problem hiding this comment.
Agree with the first suggestion, we should use the solana Pubkey type directly in a future PR. The second suggestion would just keep us using the ad-hoc unsafe functions we should scrap.
Reisen
reviewed
Aug 24, 2022
Reisen
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR :
c_oracle_header.rsand replaces all the bindgen structs by the new structs.