Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For one of the latest steps of the migration we're going to restrict the C code to the aggregation logic.
This requires exporting the function
upd_aggregatefrom C to Rust. We're doing similar logic to exporting the c_entrypoint fromoracle.c.A subtle difficulty is that
cargo testruns in the system architecture, so we need to compileupd_aggregateto this target as well. That's the goal offor_cargo_test/cpyth_test.c. This will allow usingupd_aggregatein the tests.Of course there's danger that our rust tests pass but our production code fails because they're compiling to different targets but this problem already existed with
test_oracle.cwhich is also getting compiled to the system's target. Integration tests (currently pytest) should pick this up.