Upd price in rust #248
Upd price in rust #248
Conversation
| #[error("InvalidWritableAccount")] | ||
| InvalidWritableAccount = 607, | ||
| #[error("InvalidWritableAccount")] | ||
| #[error("InvalidFreshAccount")] |
There was a problem hiding this comment.
This message was a typo
| # Compile C code to system architecture for use by rust's cargo test | ||
| $(CC) -c ./src/oracle/for_cargo_test/cpyth_test.c -o ./target/cpyth_test.o | ||
| gcc -c ./src/oracle/for_cargo_test/cpyth_test.c -o ./target/cpyth_test.o | ||
| # Bundle C code compiled to system architecture for use by rust's cargo test |
There was a problem hiding this comment.
Had to change this back... maybe $CC in the context of this makefile has the bpf flags?
There was a problem hiding this comment.
hmmm ok weird. i'm not really sure how this whole makefile process works, tbh.
jayantk
left a comment
jayantk
left a comment
There was a problem hiding this comment.
awesome. Left you some minor comments
Also, are you going to delete the now unused C implementations?
| # Compile C code to system architecture for use by rust's cargo test | ||
| $(CC) -c ./src/oracle/for_cargo_test/cpyth_test.c -o ./target/cpyth_test.o | ||
| gcc -c ./src/oracle/for_cargo_test/cpyth_test.c -o ./target/cpyth_test.o | ||
| # Bundle C code compiled to system architecture for use by rust's cargo test |
There was a problem hiding this comment.
hmmm ok weird. i'm not really sure how this whole makefile process works, tbh.
| ) | ||
| } | ||
|
|
||
| pub fn is_component_update(cmd_args: &cmd_upd_price_t) -> Result<bool, ProgramError> { |
There was a problem hiding this comment.
why "component"?
also, the argument to this is confusing because if you have a cmd_upd_price_t, you would expect its cmd_ field to be the corresponding int.
There was a problem hiding this comment.
Component as opposed to aggregate.
There was a problem hiding this comment.
This one is tricky : the dispatcher routes upd_price, upd_price_no_fail_on_error and agg_price to this function . The first two update the individual publisher's price, unlike agg_price which only tries to update the aggregate.
| ) | ||
| } | ||
|
|
||
| pub fn is_component_update(cmd_args: &cmd_upd_price_t) -> Result<bool, ProgramError> { |
upd_pricein rust.Also moved 3 unit tests from C to Rust.
The boundary between C and Rust becomes the
upd_aggregatefunction