Check length #236
Merged
Check length #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantk
reviewed
Aug 10, 2022
|
|
||
| /// Interpret the bytes in `data` as a value of type `T` | ||
| pub fn load<T: Pod>(data: &[u8]) -> Result<&T, ProgramError> { | ||
| try_from_bytes(&data[0..size_of::<T>()]).map_err(|_| ProgramError::InvalidArgument) |
Contributor
There was a problem hiding this comment.
nitpick: it would be nice to document the exact error conditions here. I think this errors if there aren't enough bytes to read a T in data, but is tolerant of data containing more bytes than needed.
jayantk
approved these changes
Aug 10, 2022
Contributor
jayantk
left a comment
jayantk
left a comment
There was a problem hiding this comment.
great. you can add this comment in a later PR so we don't have to go through another approval / ci if you want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More graceful error handling in load. Now it shouldn't panic if length is not right.