Simplistic trait #232
Merged
Simplistic trait #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompntn
reviewed
Aug 9, 2022
jayantk
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PythStruct trait that basically binds some constants to each type of Pyth account.
Now functions that interact with all 3 of Pyth accounts can use the trait.
I turned
load_mapping_account_mutandload_mapping_product_mutintoload_checked<T: PythStruct>and equally
initialize_mapping_accountandinitialize_product_accountintoinitialize_checked<T:PythStruct>In the future, these functions should also perform the other checks (signatures, rent, program ownership). But I'm doing it incrementally.