Skip to content

Use pubkey functions everywhere #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 9, 2022
Merged

Use pubkey functions everywhere #231

merged 10 commits into from
Aug 9, 2022

Conversation

@guibescos
Copy link
Contributor

@guibescos guibescos commented Aug 8, 2022 •
edited
Loading

Switch to using pubkey_is_zero and pubkey_equal in all files.
After this PR, the pubkey union fields shouldn't be accessed with unsafe. Instead the helper functions should be used.

Base automatically changed from rust/add-publisher to main August 9, 2022 15:26
@guibescos guibescos marked this pull request as ready for review August 9, 2022 16:07
@guibescos guibescos merged commit 09f39a5 into main Aug 9, 2022
@guibescos guibescos deleted the pubkey-functions branch August 9, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jayantk jayantk jayantk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@guibescos @jayantk