Migrate upd_product instruction #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guibescos
requested changes
Aug 8, 2022
| assert!(account_has_key_values(&product_account, &kvs).unwrap()); | ||
|
|
||
| // bad size on the string | ||
| instruction_data[0] = 7; |
Contributor
There was a problem hiding this comment.
Not sure what this test is accomplishing. You're changing the instruction discriminator.
guibescos
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This instruction was slightly tricky because of how the list of string key-value pairs is handled in the C. I made some minor changes to the implementation logic to simplify it, but they shouldn't change the semantics. Please do check that this looks right to you.
I also added my own test because we didn't have one before.