Add mapping tests #223
Add mapping tests #223
Conversation
| let next_mapping_data = load_mapping_account_mut(&next_mapping, PC_VERSION).unwrap(); | ||
| let mut cur_mapping_data = load_mapping_account_mut(&cur_mapping, PC_VERSION).unwrap(); | ||
|
|
||
| assert!(unsafe { |
There was a problem hiding this comment.
The pubkey operations are really horrible right now. They got implemented in pyth-solana-sdk, so I feel like we'll be able to fix them once we move from bindgen to pyth-solana-sdk.
There was a problem hiding this comment.
I changed my mind, I'll implement pc_pub_key_is_zero and pc_pub_key_equal and we can replace the functions when we start using pyth-solana-sdk
There was a problem hiding this comment.
Ok. I think you can merge this PR now and update the tests with those functions in a separate pr.
jayantk
left a comment
jayantk
left a comment
There was a problem hiding this comment.
looks great.
Something to think about going forward: can we implement some helpers for writing tests more concisely? The tests are rather verbose right now, and that makes it hard for us to test everything thoroughly.
add_mapping test ported to rust.
The pubkey operations are really horrible right now. They got implemented in pyth-solana-sdk, so I feel like we'll be able to fix them once we move from bindgen to pyth-solana-sdk.