Add price rust #220
Merged
Add price rust #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 1, 2022 12:16
…t into migrate_accounts
jayantk
reviewed
Aug 5, 2022
Contributor
jayantk
left a comment
jayantk
left a comment
There was a problem hiding this comment.
lgtm, will approve once you merge/rebase
program/rust/src/rust_oracle.rs
Outdated
| ) -> OracleResult { | ||
| if instruction_data.len() < size_of::<cmd_add_price_t>() { | ||
| return Err(ProgramError::InvalidArgument); | ||
| } |
Contributor
There was a problem hiding this comment.
i think we should put this check into load
program/rust/src/rust_oracle.rs
Outdated
| if product_data.magic_ != PC_MAGIC | ||
| || product_data.ver_ != cmd_args.ver_ | ||
| || product_data.type_ != PC_ACCTYPE_PRODUCT | ||
| || price_data.magic_ != 0 |
Contributor
There was a problem hiding this comment.
One thing i've noticed from doing this translation exercise is that the check for whether an account is uninitialized differs in all of the instructions. init_mapping checks both the magic and ver fields, but add_account only checks the magic. I think it should be fine for us to standardize on one of these and encode that in validate_fresh_account.
jayantk
reviewed
Aug 5, 2022
program/rust/src/rust_oracle.rs
Outdated
| .next_ | ||
| .k1_ | ||
| .copy_from_slice(&next_mapping.key.to_bytes()); | ||
| pubkey_assign(cur_mapping.next_, &next_mapping.key.to_bytes()); |
jayantk
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add price instruction in Rust.