Make c robust to price account size #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Definitely want a second pair of eyes on this |
majabbour
force-pushed
the
make-c-robust-to-price-account-size
branch
from
9410cbf to
7d43f5c
Compare
majabbour
force-pushed
the
make-c-robust-to-price-account-size
branch
from
7d43f5c to
0984ef5
Compare
guibescos
added a commit
that referenced
this pull request
Jul 28, 2022
* Make c robust to price account size (#201) * make pythd robust * made the oracle accept new size * left space for extra publishers * Make c robust to price account size (#207) * make pythd robust * made the oracle accept new size * left space for extra publishers * Intercepting price updates (#204) * changed c return value of update price to indicate aggregation (#190) * changed c return value of update price to indicate aggregation * forgot to add bindings * removed the need for casting * fixed update_no_fail * removed unnecessary docker packages * timeless coments * a convinient way to derive traits * changed importing style * added register_traits method * fixed formatting * add a new insctruction and interecepted update price calls * fixed formatting * more helpful error message for incorrect c account size * fixed merging errors * addressed some warning * updated comment * merging formatting issues * memory borrowing issues after rebasing * updated import * more import style changes * removed panics * bug introduced by merge * moved dispatching to processor * better formatting * cleaner error handling * error handling wrapper for c_entrypoint * removed unwrap * more comments * removed unused imports + changed import style Co-authored-by: majabbour <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We plan on resizing price accounts to fit the Time Machine. This PRs ensures that this does not cause existing C code to fail.
There are two places where the size of price_t not being the same as the account size can cause failures:
1-rent exempt check while validating accounts (oracle.c)
2-Decompressing the result of the RPC request to Solana requesting to read price contracts (pythd, request.cpp)
(We do not change the default new account size for Pyth-manager because it is helpful to have accounts from the old size in unit tests, and C pyth-manager is no longer used anyway)