Add C++ pythd websocket example #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantk
reviewed
Jul 5, 2022
Contributor
jayantk
left a comment
jayantk
left a comment
There was a problem hiding this comment.
the high-level approach makes sense to me. I left you some more tactical comments.
tompntn
force-pushed
the
test-publish-cpp-websockets
branch
from
e7bde6c to
1516324
Compare
ali-behjati
approved these changes
Jul 11, 2022
Collaborator
ali-behjati
left a comment
ali-behjati
left a comment
There was a problem hiding this comment.
I don't have c++ not qt expertise here but the code is very nice and clear and covers all use cases that comes to my mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates how to use C++ to publish price updates to the Pyth Network through the pythd websocket API described at https://docs.pyth.network/publish-data/pyth-client-websocket-api
It's a very rough, minimal example which demonstrates how to use the API.