Bump solana 2 #181
Merged
Bump solana 2 #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation : the oracle contract compiles with solana 1.7.2, but we'd like to use a recent version of solana for the rust parts that are gonna come next. Keeping the c code with 1.7.2 would require us having 2 versions of solana in the docker.
We'd much rather bump solana to the lastest version and using the same version to compile the c code and the rust code.
This PR bumps solana to
1.10.29. Fixing the CI required the following changes.limits.hinupd_aggregate.h. The solana c sdk doesn't play nicely with libc andsolana_sdk.hprobably has this header.SOL_TESTis defined includesolana_sdk.hinstead ofstdint.h. This change only affects criterion tests.solana.patchto only add warning flags. We remove a patch that would declared an unused function as__attribute__(( weak )).