Add support for a secondary network #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompntn
force-pushed
the
secondary-manager-subclass
branch
from
9688632 to
0744854
Compare
jayantk
previously approved these changes
Jun 21, 2022
primary is unavailable.
tompntn
force-pushed
the
secondary-manager-subclass
branch
from
c5af4d3 to
1122c89
Compare
jayantk
reviewed
Jun 22, 2022
jayantk
reviewed
Jun 22, 2022
tompntn
force-pushed
the
secondary-manager-subclass
branch
from
d8aac47 to
ba5e1a5
Compare
tompntn
force-pushed
the
secondary-manager-subclass
branch
from
ba5e1a5 to
33277e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for publishing and subscribing to updates from a secondary network.
To do this, we instantiate another instance of the
pc::managerclass, which manages the RPC connection and account subscriptions from the secondary network.pythd websocket API users are still managed soley by the primary manager, but the responses to the websocket requests are populated by the secondary manager's data if the primary manager does not have enough data to do so.