Remove old aggregation logic. #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reisen
commented
Mar 3, 2022
| @@ -1 +1 @@ | |||
| {"exponent":-8,"price":0,"conf":0,"status":"unknown"} | |||
Contributor
Author
There was a problem hiding this comment.
These are more significant changes than the test_oracle figures, as they're prices that are now considered trading instead of unknown, I'm not 100% sure how to gauge whether this is OK or not yet.
jayantk
approved these changes
Mar 3, 2022
Contributor
jayantk
left a comment
jayantk
left a comment
There was a problem hiding this comment.
lgtm. I think the test changes are fine, but do double check per the comment below.
This was referenced Apr 26, 2022
guibescos
pushed a commit
that referenced
this pull request
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the old aggregation logic and simply stores the price and confidence directly in the aggregate. This follows up on the aggregation logic in v2 extracted from #139 and removes the grafting on input to the TWAP calculation.