add rates calendar #43
Conversation
| ) | ||
| next_market_close = ( | ||
| elif dt.date() in NYSE_HOLIDAYS: | ||
| next_market_open = get_next_market_open(asset_type, dt) |
There was a problem hiding this comment.
fixed this because there was a bug where this would return incorrect answer if the given date is a holiday and the next day is early close holiday
| == format_datetime_to_unix_timestamp(datetime.datetime(2023, 6, 20, 9, 30, 0, tzinfo=NY_TZ)) | ||
| ) | ||
|
|
||
| # equity holiday next day early close holiday |
There was a problem hiding this comment.
added new test here to catch the previous bug mentioned
pythclient/calendar.py
Outdated
| return int(next_market_close.timestamp()) | ||
|
|
||
|
|
||
| def get_market_hours_clause(time_column_name): |
There was a problem hiding this comment.
Where is this gonna be used?
There was a problem hiding this comment.
data workflows for calculating publishers uptime
ali-behjati
left a comment
ali-behjati
left a comment
There was a problem hiding this comment.
This is good but I think the code is getting more and more difficult. We need to find a library to do these.
Also, might be nice to add 2024 holidays.
|
removed get_market_hours_clause because its only used in data_workflows and instead will use the calendar here in data_workflows |
add rates to calendar and move get_market_hours_clause from data_workflows repo to here as a single source of truth related to calendar logic