Skip to content

refactor #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 27, 2023
Merged

refactor #34

merged 3 commits into from
Jun 27, 2023

Conversation

@cctdaniel
Copy link
Contributor

@cctdaniel cctdaniel commented Jun 26, 2023 •
edited
Loading

address comments from previous PR #33:

  • change name to be more descriptive
  • use constants instead of fixtures
  • extract a function to format datetime string

jayantk
jayantk approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@cctdaniel cctdaniel merged commit 23fedd2 into main Jun 27, 2023
@cctdaniel cctdaniel deleted the tests branch June 27, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jayantk jayantk jayantk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cctdaniel @jayantk