Add ws support for specific feeds #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
For reference, I am trying to implement the same charts that Pyth does here: https://pyth.network/price-feeds/crypto-sol-usd?range=1H. I don't see a lot of documentation on how they do this. I am looking in the wrong places, or are these just not documented atm? |
Contributor
|
These charts work by putting the prices in an offchain database through a websocket subscription and then displaying them. The process is not open sourced. Thanks for the contribution, please rebase and we'll try to get this merged. |
…xample with SOL/USDC feed
jacksturt
force-pushed
the
add-ws-for-specific-feeds
branch
from
4ac6b77 to
3ce8d56
Compare
Contributor
Author
|
Rebased |
Contributor
|
FYI: I also cut release v2.14.0 with this change included |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe I am using this library wrong, but I could not find a way to only subscribe to specific feeds. This adds support for subscribing to a subset of feeds by providing a list of FeedIds when constructing a PythConnection Object.