fix: use both latest publisher and aggregate slot for dynamic pricing #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantk
approved these changes
Dec 1, 2023
Contributor
jayantk
left a comment
jayantk
left a comment
There was a problem hiding this comment.
👍 seems like a good adjustment. Now we only pay more if both the pub and the aggregate are behind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One publisher has tried the previous version. I noticed that often they fall behind on some specific symbols by not publishing themself and that causes a sudden increase in priority once they publish it. That is why i am also considering the aggregate slot for the pricing. I'm also excluding the non-live feeds because publishers are often more unstable on them.