fix: use solana-client pubsub lib instead of solana-shadow #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solana-shadow is not maintained anymore and doesn't work properly. It drops many updates and after a certain amount of latency drops all messages. We have been using Solana PubSub client in Hermes without any problem and there is no reason to stick with solana-shadow.
ali-behjati
commented
Nov 30, 2023
Comment on lines
484
to
502
| if !ret { | ||
| debug!(self.logger, "Exporter: Attempted to publish price outside market hours"; | ||
| "price_account" => key_from_id.to_string(), | ||
| "weekly_schedule" => format!("{:?}", weekly_schedule), | ||
| "utc_time" => now.format("%c").to_string(), | ||
| ); | ||
| } | ||
|
|
||
| ret | ||
| if !ret { | ||
| debug!(self.logger, "Exporter: Attempted to publish price outside market hours"; | ||
| "price_account" => key_from_id.to_string(), | ||
| "weekly_schedule" => format!("{:?}", weekly_schedule), | ||
| "utc_time" => now.format("%c").to_string(), | ||
| ); | ||
| } | ||
|
|
||
| ret | ||
| } else { | ||
| // Note: This message is not an error. Some | ||
| // publishers have different permissions on | ||
| // primary/secondary networks | ||
| debug!( | ||
| self.logger, | ||
| "Exporter: Attempted to publish a price without permission, skipping"; | ||
| "unpermissioned_price_account" => key_from_id.to_string(), | ||
| "permissioned_accounts" => format!("{:?}", self.our_prices) | ||
| ); |
ali-behjati
commented
Nov 30, 2023
drozdziak1
reviewed
Nov 30, 2023
ali-behjati
force-pushed
the
fix-ws
branch
2 times, most recently
from
25af1fd to
2d336e0
Compare
drozdziak1
reviewed
Nov 30, 2023
drozdziak1
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solana-shadow is not maintained anymore and doesn't work properly. It drops many updates and after a certain amount of latency drops all messages. We have been using Solana PubSub client in Hermes without any problem and there is no reason to stick with solana-shadow.