Request compute units per price update instruction #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompntn
approved these changes
Feb 15, 2023
tompntn
reviewed
Feb 15, 2023
src/agent/solana/exporter.rs
Outdated
| // Pay priority fees, if configured | ||
| instructions.push(ComputeBudgetInstruction::set_compute_unit_limit( | ||
| self.config.compute_unit_limit, | ||
| self.config.compute_unit_limit * refreshed_batch_size, |
Contributor
There was a problem hiding this comment.
I think this should actually be the length of the instructions vector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new pyth agent seems to request 20k CUs for the entire transaction
https://explorer.solana.com/tx/5zzK9k3pBrL7aH4jMrSrYLjT5AnqbRqu4aE5gK7ozF3MRCzdhhCrcXZu3Fdzo5uUiYF3YdrVAoVfvkJK29rrzuMU
but the old agent seems to request 20k CUs per price update instruction in the transaction:
https://explorer.solana.com/tx/4ASipr9GayTsejvRxLneWiMaZXdbwASo6iGtTYLM3pwwMU1u7X1HZ94K9Lvs2ntNQn45zt1EZ6V9xANwRfyx7kYJ
This explains why the new pyth-agent is running out of compute on mainnet. This PR changes it to request cus per instruction.