Pythd JRPC Websocket Server #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompntn
force-pushed
the
pythd-jrpc-api
branch
from
a8d52c8 to
1f478f9
Compare
Reisen
approved these changes
Sep 5, 2022
Contributor
Reisen
left a comment
Reisen
left a comment
There was a problem hiding this comment.
Looks good. After reading through it a bit more, I think the Connection type
is being used as a bit of a mishmash for any method related to converting
between the adaptor and websockets which is leading to everything being added
on as a method, but some of this can probably be split out. At least the name
doesn't fully convey how much responsibility this type has.
Fine for now though and otherwise all looks awesome!
drozdziak1
added a commit
that referenced
this pull request
May 9, 2023
* oracle.rs: hotfix: Remove stray loop break * test_integration.py: add a second publisher for permissions testing * nudge GitHub * nudge GitHub #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a websocket server which speaks the Pythd JRPC protocol. It doesn't include any business logic, just the websocket server and the shape of the JRPC messages to it's clients.
The server delegates handling of requests to an
Adapter, allowing us to mock the business logic out in tests. EachConnectioncommunicates to theAdapterusing a Tokio channel.Each
Connectionhas anotify_price_rxandnotify_price_sched_rxchannel. When a message is received on one of these, the correspondingnotify_price/notify_price_schedJRPC notification is sent to theConnections client.