refactor: migrate adapter service to api #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reisen
force-pushed
the
push-qywryorxvyvr
branch
from
48b59c1 to
9d3cb67
Compare
Reisen
commented
Apr 22, 2024
| tokio::task::spawn(serve).await.map_err(|e| e.into()) | ||
| } | ||
|
|
||
| #[cfg(test)] |
Contributor
Author
There was a problem hiding this comment.
Actually there is some value to these, I will bring these back but in a slightly different form.
Collaborator
There was a problem hiding this comment.
i think the adaptor tests are a bit useless but this is good.
ali-behjati
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Adapter to remove the running service component. The goal behind this is to remove the channel communication between the adapter and other components, instead, Adapter now acts as an API. The Adapter API currently is a single nameless trait with all functionality combined, this change will allow splitting that API out into relevant components to better isolate functionality. For now though, this just moves the entire API into a temporary trait called
AdapterApi, in future PR's,adapter/will becomestate/and the relevant functionality will be broken out.Apart from the
AdapterApiand channel removal, all other changes are mechanical, just propagating the change through the codebase.Some changes that occurred during this refactoring:
.../adapter/api.rsto replace the only meaningful runtime component of adapter.Sparameter is added anywhere Adapter used to be relied on.++incrementbehaviourincrement++AdapterApiis now strongly typed, so the rpc.rs API now does proper verification of accounts in the right place.AdapterApi