fix: remove adapter <> api deadlock #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-behjati
commented
Feb 23, 2024
| self.update_our_prices(&publish_keypair.pubkey()); | ||
|
|
||
| debug!(self.logger, "Exporter: filtering prices permissioned to us"; | ||
| "our_prices" => format!("{:?}", self.our_prices), |
Collaborator
Author
There was a problem hiding this comment.
this log is so huge and not very useful.
ali-behjati
commented
Feb 23, 2024
| trace!( | ||
| self.logger, | ||
| "Exporter: No more permissioned price accounts in channel, using cached value"; | ||
| "cached_value" => format!("{:?}", self.our_prices), |
Collaborator
Author
There was a problem hiding this comment.
same as above.
ali-behjati
force-pushed
the
fix/deadlock
branch
from
cbd862c to
47185bc
Compare
guibescos
reviewed
Feb 23, 2024
| Ok(()) => {} | ||
| Err(_e) => { | ||
| warn!(logger, "remote_keypair_loader: Could not send back secondary keypair to channel"; | ||
| ); |
Contributor
There was a problem hiding this comment.
lol what was this styling
Adapter sends price update notifications to the subscriber API connection actor but at the same time the subscriber actor can get blcoked on receiving messages (e.g. product info) from Adapter. If the channel from Adapter to the subscriber gets full the Adapter can get blocked and this results in a deadlock. This situation propagates and queues messages in other actors and WS messages from the clients will grow in an unbounded queue that results in a constant memory growth (leak). This change simply makes the Adaptor to subscriber API connection nonblocking by dropping messages if the channels are full.
ali-behjati
force-pushed
the
fix/deadlock
branch
from
47185bc to
56b803d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapter sends price update notifications to the subscriber API connection actor but at the same time the subscriber actor can get blcoked on receiving messages (e.g. product info) from Adapter. If the channel from Adapter to the subscriber gets full the Adapter can get blocked and this results in a deadlock. This situation propagates and queues messages in other actors and WS messages from the clients will grow in an unbounded queue that results in a constant memory growth (leak).
This change simply makes the Adaptor to subscriber API connection nonblocking by dropping messages if the channels are full.