Skip to content

Fix typos #9424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 27, 2021
Merged

Fix typos #9424

merged 3 commits into from
Dec 27, 2021

Conversation

@kianmeng
Copy link
Contributor

@kianmeng kianmeng commented Dec 18, 2021

  • Allow maintainers to push and squash when merging my commits. Please uncheck this if you prefer to squash the commits yourself.
  • Add yourself to AUTHORS in alphabetical order.

asottile
asottile reviewed Dec 22, 2021
View reviewed changes
doc/en/how-to/fixtures.rst Outdated
FAILED test_module.py::test_ehlo[smtp.gmail.com] - assert 0
FAILED test_module.py::test_noop[smtp.gmail.com] - assert 0
FAILED test_module.py::test_ehlo[mail.python.org] - AssertionError: asser...
FAILED test_module.py::test_ehlo[mail.python.org] - AssertionError: assert...
Copy link
Member

@asottile asottile Dec 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a typo, this is terminal output, same for the rest of the similar ones

The-Compiler
The-Compiler approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@The-Compiler The-Compiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks!

nicoddemus
nicoddemus approved these changes Dec 27, 2021
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicoddemus nicoddemus added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Dec 27, 2021
@nicoddemus nicoddemus merged commit 55debfa into pytest-dev:main Dec 27, 2021
nicoddemus pushed a commit to nicoddemus/pytest that referenced this pull request Dec 27, 2021
@kianmeng @nicoddemus
Fix typos (pytest-dev#9424)
e62daed
@kianmeng
Copy link
Contributor Author

kianmeng commented Dec 27, 2021

👍 🎉

nicoddemus added a commit that referenced this pull request Dec 27, 2021
@nicoddemus @kianmeng
Fix typos (#9424) (#9448)
161841d 
Co-authored-by: Kian Meng, Ang <[email protected]>
@nicoddemus
Copy link
Member

nicoddemus commented Dec 27, 2021

Backported: #9448

@nicoddemus nicoddemus added backported and removed needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch labels Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@The-Compiler The-Compiler The-Compiler approved these changes

@nicoddemus nicoddemus nicoddemus approved these changes

@asottile asottile Awaiting requested review from asottile

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kianmeng @nicoddemus @The-Compiler @asottile