-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add template for prereleases #9165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @king-alexander, From #8820 I take we also need to update |
Hey @nicoddemus! I appreciate your comment. I'm new to open source and using Hacktoberfest as an opportunity to get more involved. Yes, |
No worries, take your time, and let us know if you have any questions! |
Hey @nicoddemus thanks! I do have a question. Under what condition should the prerelease template be used versus the minor release template or patch template? @The-Compiler mentions passing the is_major option to release.py, but don't we need another condition to pick between 3 different templates? |
At the moment Line 13 in e84ba80
And based on that, decides which template to use: Lines 25 to 27 in e84ba80
I suggest we explicitly pass the name of template, so pytest/scripts/prepare-release-pr.py Line 85 in e84ba80
|
@nicoddemus Let me know what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @king-alexander for the updates, left a few more comments, please take a look!
Co-authored-by: Bruno Oliveira <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Bruno Oliveira <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @king-alexander!
Thank you @nicoddemus! I'm grateful for the chance to contribute 🙂 |
@nicoddemus Is this good to merge? |
Yes, thanks for the ping! Merging. |
Just catching up on pytest 7.0.0 in the last couple of days - thanks @king-alexander and @nicoddemus, great work! 👍 |
Close #8820