Fix required_plugins with prereleases #8469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-Compiler
commented
Mar 19, 2021
| for required_plugin in required_plugins: | ||
| try: | ||
| spec = Requirement(required_plugin) | ||
| req = Requirement(required_plugin) |
Member
Author
There was a problem hiding this comment.
Took the freedom to rename this, as spec is very close to specifier (another thing in packaging, see .specifier below) which I found confusing.
| pytest.param( | ||
| """ | ||
| [pytest] | ||
| required_plugins = myplugin==1.6 |
Member
Author
There was a problem hiding this comment.
Look at the two commits individually to get a better diff (also see the comment below).
The-Compiler
force-pushed
the
required-prereleases
branch
from
c0398f8 to
57e69b5
Compare
nicoddemus
approved these changes
Mar 19, 2021
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
LGTM, thanks! Left a small CHANGELOG suggestion.
Co-authored-by: Bruno Oliveira <[email protected]>
Member
Author
|
Thanks @nicoddemus for the review, and @RonnyPfannschmidt @asottile for the suggestions in #8456! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8456