-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add pyupgrade-docs to pre-commit #8366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
LGTM, thanks a lot for that and writing https://github.com/verhovsky/pyupgrade-docs. 👍 Could you also add that to our pre-commit configuration? Thanks! |
|
@nicoddemus done. thanks for writing/maintaining pytest, it's one of my favorite libraries! |
nicoddemus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
(Note to squash this before we merge it)
asottile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just making sure you saw this @verhovsky (since you're not watching the repo): verhovsky/pyupgrade-docs#3
nicoddemus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @verhovsky!
@asottile anything else needs to be done here?
yeah we probably shouldn't use the tool since it integrates in an incompatible and unsupported way (and likely will either break or be stuck on an old version) |
|
@asottile thanks! @verhovsky thanks anyway for the PR! Perhaps once the issues (which I'm not familiar with TBH) are fixed, you can open another PR? Thanks! |
|
@asottile any opinion on allowing pyupgrade to be invoked as a python function? i'm under the impression they just don't want to take a "i has no api" and i see providing a explicit minimal api as opportunity to make tooling easier |
|
no I don't want to provide an api because it paints me into a corner and prevents me from adding features. the only supported api is the entrypoint |
|
@asottile i was thinking along the lines of exposing a "limited" api in the sense of having only a |
|
no thanks, they might as well use the entrypoint at that point |
|
@asottile i see, in that case it may be necessary to document that, also stdio replacement is still a pain |
a follow up to #5705
since pytest supports only Python 3.6+, we can use f-strings in the documentation