pathlib: fix symlinked directories not followed during collection #7982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
added
the
needs backport
nicoddemus
approved these changes
Oct 31, 2020
bluetech
added a commit
to bluetech/pytest
that referenced
this pull request
Oct 31, 2020
pathlib: fix symlinked directories not followed during collection (cherry picked from commit a14a229)
Merged
bluetech
added a commit
to bluetech/pytest
that referenced
this pull request
Oct 31, 2020
pathlib: fix symlinked directories not followed during collection (cherry picked from commit a14a229) Changed pytester -> testdir.
bluetech
commented
Oct 31, 2020
| """A symlinked directory is collected.""" | ||
| dir = pytester.mkdir("dir") | ||
| dir.joinpath("test_it.py").write_text("def test_it(): pass", "utf-8") | ||
| pytester.path.joinpath("symlink_dir").symlink_to(dir) |
Member
Author
There was a problem hiding this comment.
Hmm, should have used symlink_or_skip here, and absent that, should have used symlink_to(dir, target_is_directory=True). I wonder how it passed windows CI without it. Will fix it anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7981.