mark/structure: fix pylint complaining that builtin marks are not callable #7476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
reviewed
Jul 10, 2020
| parametrize = None # type: _ParametrizeMarkDecorator | ||
| usefixtures = None # type: _UsefixturesMarkDecorator | ||
| filterwarnings = None # type: _FilterwarningsMarkDecorator | ||
| skip = cast(_SkipMarkDecorator, None) |
Member
There was a problem hiding this comment.
Perhaps leave a TODO note to use proper type annotations once we drop Python 3.5?
Member
Author
There was a problem hiding this comment.
I actually had it in my unsaved editor buffer 🤦 Pushed now.
nicoddemus
approved these changes
Jul 10, 2020
bluetech
force-pushed
the
pylint-callable
branch
from
8f4fbe7 to
c1ca42b
Compare
sdimitro
added a commit
to sdimitro/sdb-dlpx
that referenced
this pull request
Jul 29, 2020
Context: Issue: pytest-dev/pytest#7473 PR that was just merged: pytest-dev/pytest#7476 Opened issue to get rid of this once `pytest` is updated: delphix#235
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7473.
It seems that pylint doesn't understand TYPE_CHECKING and/or the type comments, and thinks
parametrizeand friends areNone, and then complains that they are not callable.The solution is a little uglier but seems to do the trick. On Python 3.6 we can use the nice syntax, which I also tested and will work.