Skip to content

Prevent multiple collecting of the same file due to recursive symlinks #7355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Prevent multiple collecting of the same file due to recursive symlinks #7355

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
569dfaf
Add test for collecting recursive symlinks
aklajnert Sep 11, 2022
be245dc
Add xfail to the recursive symlink tests
aklajnert Sep 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions testing/test_collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,32 @@ def test_testpaths_ini(self, pytester: Pytester, monkeypatch: MonkeyPatch) -> No
items, reprec = pytester.inline_genitems()
assert [x.name for x in items] == ["test_%s" % dirname]

@pytest.mark.xfail(sys.platform == "linux", reason="GitHub #624")
@pytest.mark.parametrize("absolute", [True, False])
def test_recursive_symlinks(self, pytester, absolute):
"""Make sure recursive symlinks won't cause multiple collection of the same file."""
directory = pytester.mkdir("dir")
ensure_file(directory / "test_recursive.py").write_text(
"def test_recursive(): pass"
)
symlink_or_skip(str(directory) if absolute else ".", "dir/link")

items, _ = pytester.inline_genitems()
assert len(items) == 1

@pytest.mark.xfail(sys.platform == "linux", reason="GitHub #624")
def test_multiple_recursive_symlinks(self, pytester):
"""Symlink points to recursive symlink. Should be resolved to the very end."""
directory = pytester.mkdir("dir")
ensure_file(directory / "test_recursive.py").write_text(
"def test_recursive(): pass"
)
symlink_or_skip(".", "dir/link")
symlink_or_skip("link", "dir/link2")

items, _ = pytester.inline_genitems()
assert len(items) == 1


class TestCollectPluginHookRelay:
def test_pytest_collect_file(self, pytester: Pytester) -> None:
Expand Down