Issue 6471 - Introduce new option to skip header and summary #7258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symonk
reviewed
May 25, 2020
Member
|
Hi @piotrhm thanks for working on this. Could you add some test(s) to cover such scenarios as well if you get a chance? :) |
Contributor
Author
|
@symonk thanks for comments! I added tests and changed ._addoption signature. I will be grateful if you take a look at current code. |
nicoddemus
approved these changes
Jun 9, 2020
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks a lot @piotrhm!
Took the liberty of improving the CHANGELOG a bit and rebasing on master. 👍
Member
|
Sorry, should have squashed this one... 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements suggested approach for issue #6471.
Fix #6471.