Issue 1120 Cleaning up tmpdir's #6944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrhm
changed the title
bluetech
changed the title
nicoddemus
reviewed
Mar 27, 2020
| keep=keep, | ||
| consider_lock_dead_if_created_before=consider_lock_dead_if_created_before, | ||
| # Register a cleanup for program exit | ||
| atexit.register( |
Member
There was a problem hiding this comment.
This might still fail because some pytest process will finish before others so they might still step in each others toes, I guess?
Contributor
Author
There was a problem hiding this comment.
Do you mean one of the race condition cases mentioned in maybe_delete_a_numbered_dir()? I thought try_cleanup() invoked from cleanup_numbered_dir() is preventing from such case or at least we have some guarantees - based on comments from maybe_delete_a_numbered_dir().
Member
|
@RonnyPfannschmidt gentle ping. |
RonnyPfannschmidt
approved these changes
Jun 9, 2020
Member
|
I guess this is very hard to add a test for right? Rebased. |
Member
|
Hi @piotrhm! Thanks again and sorry for the long delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I combined work done by @bitmuster and @caitelatte which close #1120. Solution is a proposition which addresses @RonnyPfannschmidt comments available here.