Skip to content

Assorted improvements following up #6658 #6782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2020
Merged

Assorted improvements following up #6658 #6782

merged 1 commit into from
Mar 27, 2020

Conversation

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Feb 20, 2020

No description provided.

@nicoddemus nicoddemus requested a review from blueyed February 20, 2020 21:53
@nicoddemus
Copy link
Member Author

nicoddemus commented Feb 20, 2020

In general I've started to play around with making the terminal writer handle a pygments Token stream, which allows for e.g. LineMatcherFailed exceptions to be colored / tokenized.

Definitely! We should use this for all custom failure exceptions (text diff, list diffs, etc) like has been done in ward.

Interesting idea of supporting pygments token streams directly in our subclass, had not thought about that.

@nicoddemus
Copy link
Member Author

nicoddemus commented Feb 20, 2020

Interesting idea of supporting pygments token streams directly in our subclass, had not thought about that.

We can probably see how popular the color feature is (I suspect huge), so we can then see if there are problems on depending on pygments directly (I think none).

RonnyPfannschmidt
RonnyPfannschmidt approved these changes Feb 21, 2020
View reviewed changes
src/_pytest/_code/code.py
character, as doing so might break line continuations.
"""

indent_size = 4
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt Feb 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that diff was fun, without expanding it looks ike a api change

@blueyed

This comment has been minimized.

Sign in to view
@nicoddemus nicoddemus merged commit 429a28e into pytest-dev:master Mar 27, 2020
@nicoddemus nicoddemus deleted the code-highlight-followup branch March 27, 2020 11:58
@nicoddemus nicoddemus mentioned this pull request Mar 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

@blueyed blueyed Awaiting requested review from blueyed

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicoddemus @blueyed @RonnyPfannschmidt