Skip to content

Fix node ids which contain a parametrized empty-string variable #6607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2020
Merged

Fix node ids which contain a parametrized empty-string variable #6607

merged 1 commit into from
Jan 29, 2020

Conversation

@asottile
Copy link
Member

@asottile asottile commented Jan 28, 2020 •
edited
Loading

I went with features as this changes the node ids -- I could target master instead if this is desirable as a bugfix.

partially fixes #6597

@asottile asottile mentioned this pull request Jan 28, 2020
Open
@blueyed
Copy link
Contributor

blueyed commented Jan 29, 2020

LGTM, but typically it is called "nodeids".

@asottile asottile merged commit 595d62b into pytest-dev:features Jan 29, 2020
@asottile asottile deleted the empty_string_parametrize_nodeid branch January 29, 2020 16:42
@RonnyPfannschmidt RonnyPfannschmidt mentioned this pull request Dec 16, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asottile @blueyed @RonnyPfannschmidt