Skip to content

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jan 15, 2020

No description provided.

@nicoddemus

This comment has been minimized.

@blueyed blueyed closed this Jan 15, 2020
@blueyed blueyed deleted the ci-travis-cleanup branch January 15, 2020 12:47
@blueyed blueyed changed the title [WIP] ci: Travis: remove most jobs running on GitHub now [DEBUG/WIP] ci: Travis: remove most jobs running on GitHub now Jan 17, 2020
@blueyed blueyed restored the ci-travis-cleanup branch January 17, 2020 03:28
@blueyed blueyed reopened this Jan 17, 2020
@blueyed blueyed force-pushed the ci-travis-cleanup branch 5 times, most recently from 40d975a to e6d40b9 Compare January 23, 2020 19:36
@blueyed

This comment has been minimized.

blueyed added a commit to blueyed/pytest that referenced this pull request Jan 24, 2020
This should make it obvious if missing coverage is due to the upload
having failed.

Using pytest-dev#6553 would be an
alternative, but this can be used already if that takes longer.

Ref: pytest-dev#6463 (comment)
blueyed added a commit to blueyed/pytest that referenced this pull request Jan 24, 2020
This should make it obvious if missing coverage is due to the upload
having failed.

Using pytest-dev#6553 would be an
alternative, but this can be used already if that takes longer.

Ref: pytest-dev#6463 (comment)
@blueyed blueyed force-pushed the ci-travis-cleanup branch 2 times, most recently from 3567526 to e2f132f Compare January 24, 2020 19:26
@nicoddemus
Copy link
Member

It seems the coverage is fine now at 96.27%, awesome.

I see the only one job running in Travis is to cover the 3.5.0/1 support code. We have two options:

  1. Keep Travis running that job only.
  2. Keep the 3.5.0/1 code uncovered.

@blueyed
Copy link
Contributor Author

blueyed commented Jan 30, 2020

Yeah, keeping Travis for that job should be good.

Haven't checked this PR lately, but can clean it up / finish it later.

@nicoddemus
Copy link
Member

Sounds good!

@blueyed blueyed mentioned this pull request Feb 8, 2020
blueyed added a commit to blueyed/pytest that referenced this pull request Feb 8, 2020
3.5.1 fails there currently and I do not feel like we should cover it
here anymore.

Ref: pytest-dev#6691 (comment)
Ref: pytest-dev#6463.
@blueyed
Copy link
Contributor Author

blueyed commented Feb 8, 2020

@nicoddemus please take over.
FWIW 3.5.1 works for whatever reason in my fork.
You might want to remove it (Travis) here completely.

@blueyed blueyed closed this Feb 8, 2020
@blueyed blueyed deleted the ci-travis-cleanup branch February 8, 2020 23:51
@hugovk
Copy link
Member

hugovk commented Feb 9, 2020

One thing Travis might be useful for:

3.9-dev to test Python 3.9 alpha, ahead of it's full release in October, to avoid any surprises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants