Skip to content

Preparing release version 5.2.3 #6190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2019
Merged

Preparing release version 5.2.3 #6190

merged 2 commits into from
Nov 14, 2019

Conversation

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Nov 14, 2019

No description provided.

@nicoddemus
Copy link
Member Author

nicoddemus commented Nov 14, 2019

Not sure, but travis seems to have missed my update, but the previous commit passed fine so I think we're good to go here.

@blueyed
Copy link
Contributor

blueyed commented Nov 14, 2019

Not sure, but travis seems to have missed my update

Because of "[skip ci]".. ;)

but the previous commit passed fine so I think we're good to go here.

👍

blueyed
blueyed approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@blueyed blueyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicoddemus
Copy link
Member Author

nicoddemus commented Nov 14, 2019 •
edited
Loading

Rá duh! 😁

Thanks

@nicoddemus
Copy link
Member Author

nicoddemus commented Nov 14, 2019

Oh no, this will probably cause it to also skip the deploy when I push the tag... will have to ammend I'm afraid. 😓

asottile
asottile approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicoddemus nicoddemus merged commit e856638 into pytest-dev:master Nov 14, 2019
@nicoddemus nicoddemus deleted the release-5.2.3 branch November 14, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asottile asottile asottile approved these changes

+1 more reviewer

@blueyed blueyed blueyed approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicoddemus @blueyed @asottile