Fix rm_rf tests #6136
Merged
Fix rm_rf tests #6136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 5, 2019
blueyed
force-pushed
the
fix-rm_rf-tests
branch
from
e4869d7 to
d809692
Compare
RonnyPfannschmidt
requested changes
Nov 6, 2019
Member
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
looks good, but is only a workaround , not a fix
all this does it have pytest itself clean up a bit better, we would still fail for other code
please add a changelog entry
Contributor
Author
We won't fail really, but only emit a warning - I think that's fair/good.
I do not think we need a changelog that state we fixed our own tests really, do we? |
RonnyPfannschmidt
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5974.
Via #5974 (comment).