Skip to content

Conversation

@zak-hassan
Copy link
Contributor

@zak-hassan zak-hassan commented Nov 5, 2019

First off thank you for providing great open source pytest. Wanted to make a small bug fix. I see your reassigning a variable explanation = explanation then using it below that. Didn't make logically sense. So I thought would be nice to send a bug fix.

  • Target the master branch for bug fixes, documentation updates and trivial changes.
  • Target the features branch for new features, improvements, and removals/deprecations.
  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.

Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:

  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.
  • Add yourself to AUTHORS in alphabetical order;

@zak-hassan
Copy link
Contributor Author

Why did that codecov fail. Must be cause I removed a line of code??

@The-Compiler
Copy link
Member

Thanks! cc @asottile who introduced this (probably by accident) in be2be04.

Codecov fails because the project coverage slightly dropped as a previously covered line is now gone - this isn't a problem, though.

@The-Compiler The-Compiler merged commit 990d75b into pytest-dev:master Nov 5, 2019
@asottile
Copy link
Member

asottile commented Nov 5, 2019

hmm yeah automated tooling sometimes exposes the nonsense that was already there 😆 (this used to be explanation = ecu(explanation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants