Skip to content

Replace py.io.TextIO with io.StringIO #6064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2019
Merged

Replace py.io.TextIO with io.StringIO #6064

merged 1 commit into from
Oct 26, 2019

Conversation

@bluetech
Copy link
Member

@bluetech bluetech commented Oct 26, 2019

In Python3, py.io.TextIO is just an alias to io.StringIO. Remove the indirection.

@bluetech
Replace py.io.TextIO with io.StringIO
0b8c355 
In Python3, py.io.TextIO is just an alias to io.StringIO. Remove the
indirection.
nicoddemus
nicoddemus approved these changes Oct 26, 2019
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@nicoddemus nicoddemus merged commit ac633b8 into pytest-dev:master Oct 26, 2019
@blueyed
Copy link
Contributor

blueyed commented Oct 27, 2019

Thanks for this!
Just wanted to note that this is not really a bugfix, and would have been better off in features.

@asottile
Copy link
Member

asottile commented Oct 29, 2019

Thanks for this!
Just wanted to note that this is not really a bugfix, and would have been better off in features.

Seems to perfectly fit the bill for trivial to me -- master seems appropriate

@blueyed
Copy link
Contributor

blueyed commented Oct 29, 2019

Well, it was causing conflicts with typing changes (also from @bluetech IIRC).
I think cleanups should happen not in the stable branch (master), but where code has changed already more (features).
I can see that the PR template might indicate that master is better fitting, but that does not make it necessarily true.

@blueyed
Copy link
Contributor

blueyed commented Oct 29, 2019 •
edited
Loading

Also "trivial" is more like fixing some typo in my opinion, not changing imports in multiple files.

@asottile
Copy link
Member

asottile commented Oct 29, 2019

this change literally does nothing, they are referrentially equal -- if this isn't trivial I don't know what is

blueyed added a commit to blueyed/pytest that referenced this pull request Oct 29, 2019
@blueyed
Revisit PR template [ci skip]
dc02cf4 
- make it clear that the text should be deleted, which is often not the
  case - resulting in handling it as incomplete TODOs
- clarify targetting master/features and make it a single actionable
  item.  Ref: pytest-dev#6064 (comment)
- fix punctuation
@blueyed blueyed mentioned this pull request Oct 29, 2019
Closed
@blueyed
Copy link
Contributor

blueyed commented Oct 29, 2019 •
edited
Loading

=> #6104

@bluetech bluetech deleted the py.textio-stringio branch February 28, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bluetech @blueyed @asottile @nicoddemus