Skip to content

Remove redundant mention from 5.2.0 release notes. #5983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2019
Merged

Remove redundant mention from 5.2.0 release notes. #5983

merged 1 commit into from
Oct 17, 2019

Conversation

@aklajnert
Copy link
Contributor

@aklajnert aklajnert commented Oct 17, 2019

I got mentioned twice in the 5.2.0 release notes - once by full name and once by the username. I've removed the username mention.

@aklajnert aklajnert requested a review from nicoddemus October 17, 2019 13:20
@blueyed
Copy link
Contributor

blueyed commented Oct 17, 2019

JFI: Due to different commit authors apparently: 10bf6aa / f2f3ced.

@blueyed blueyed merged commit 813ef9e into pytest-dev:master Oct 17, 2019
@aklajnert
Copy link
Contributor Author

aklajnert commented Oct 17, 2019

JFI: Due to different commit authors apparently: 10bf6aa / f2f3ced.

Probably. I know I had slightly messed up config between Windows and Ubuntu on my PC so at some point I've probably did a commit with a different e-mail.

Thanks for merge.

@aklajnert aklajnert deleted the fix_5.2.0_announce branch October 17, 2019 13:41
@aklajnert aklajnert removed the request for review from nicoddemus October 17, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@blueyed blueyed blueyed approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aklajnert @blueyed