Skip to content

tests: keep numpy being optional #5977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2019
Merged

tests: keep numpy being optional #5977

merged 1 commit into from
Oct 16, 2019

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Oct 16, 2019

nicoddemus
nicoddemus approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, thanks! 👍

@blueyed blueyed mentioned this pull request Oct 16, 2019
Merged
6 tasks
@nicoddemus nicoddemus merged commit 3cb1457 into pytest-dev:master Oct 16, 2019
@blueyed blueyed deleted the numpy branch October 16, 2019 23:23
@blueyed
Copy link
Contributor Author

blueyed commented Oct 16, 2019

Even improved coverage: https://codecov.io/gh/pytest-dev/pytest/compare/77a995ffada780b8136740b0ff468189b60bda7a...90dfee5da55f4b2e55a92568186dc435624d5499/changes :)

@blueyed
Copy link
Contributor Author

blueyed commented Oct 17, 2019

@nicoddemus @asottile
JFI: I prefer to merge approved PRs myself, so that I can time this for them to e.g. not block CI while working on other PRs.

@nicoddemus
Copy link
Member

nicoddemus commented Oct 17, 2019

JFI: I prefer to merge approved PRs myself, so that I can time this for them to e.g. not block CI while working on other PRs.

No problem, I will keep that in mind, thanks for the heads up! 👍

@blueyed blueyed mentioned this pull request Oct 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blueyed @nicoddemus