Skip to content

Workaround curl bug which makes retries of fetching codecov.io/bash not work #5951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2019
Merged

Workaround curl bug which makes retries of fetching codecov.io/bash not work #5951

merged 1 commit into from
Oct 12, 2019

Conversation

@bluetech
Copy link
Member

@bluetech bluetech commented Oct 12, 2019

Fetching this URL is very flaky, even after adding retries. I found a possible explanation here: python-trio/trio#1231, let's try it!

@nicoddemus nicoddemus merged commit 1555973 into pytest-dev:master Oct 12, 2019
@blueyed
Copy link
Contributor

blueyed commented Oct 23, 2019

JFI: might still fail:

+ curl -S -L --connect-timeout 5 --retry 6 -s https://codecov.io/bash -o codecov-upload.sh
curl: (52) Empty reply from server

https://pytest-dev.visualstudio.com/pytest/_build/results?buildId=2556&view=logs&jobId=b93ccf05-0a7e-58c4-578e-33859c8603c3&taskId=5025fdd7-3029-57fb-e408-894fff7790eb&lineStart=119&lineEnd=121&colStart=1&colEnd=1

@njsmith njsmith mentioned this pull request Oct 25, 2019
Closed
@bluetech bluetech deleted the codecov-connect-timeout branch February 28, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bluetech @blueyed @nicoddemus