Skip to content

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Oct 6, 2019

No description provided.

@blueyed blueyed added the type: infrastructure improvement to development/releases/CI structure label Oct 6, 2019
@blueyed blueyed changed the title ci: test oldest supported attrs [ci skip] ci: test oldest supported attrs Oct 6, 2019
extras = testing
deps =
oldattrs: attrs==17.4.0
oldattrs: hypothesis<=4.38.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hypothesis 4.38.2 bumped the attrs requirement itself.

@blueyed
Copy link
Contributor Author

blueyed commented Oct 6, 2019

@asottile
Copy link
Member

asottile commented Oct 6, 2019

I think we should instead >=19.2 on features

@nicoddemus
Copy link
Member

I think we should instead >=19.2 on features

That's arguable, but neverthless it doesn't discard this PR, we don't know when features will get released.

Back to the point, not sure we should require attrs>=19.2: we are an upstream library which is loaded into the user's runtime, so we should be careful when to bump our minimal requirements, specially for a widely used library such as attrs.

Given that so far this is the only issue that has bitten us, I would leave it alone. If more issues start to creep in, we should definitely reconsider this though.

@nicoddemus nicoddemus merged commit cfa9ebc into pytest-dev:master Oct 6, 2019
@blueyed blueyed deleted the oldattrs branch October 6, 2019 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: infrastructure improvement to development/releases/CI structure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants