Skip to content

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Oct 6, 2019

Noticed this with tests for pdb++.

@blueyed
Copy link
Contributor Author

blueyed commented Oct 6, 2019

Note that it still tries to rewrite it (

self._warn_already_imported(name)
self._must_rewrite.update(names)
), and might succeed (likely due to the "pdb" module being re-imported explicitly in the tests).

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changelog, otherwise LGTM. 👍

@nicoddemus
Copy link
Member

Needs rebase once #5923 is merged

@blueyed
Copy link
Contributor Author

blueyed commented Oct 6, 2019

Missing changelog, otherwise LGTM. 

Isn't that just noise? (quite internal isn't it?).

@nicoddemus
Copy link
Member

Isn't that just noise? (quite internal isn't it?)

Fair enough. 👍

@blueyed blueyed merged commit cd398e2 into pytest-dev:features Oct 6, 2019
@blueyed blueyed deleted the lazy-import-pdb branch October 6, 2019 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants