Fix the scope behavior with indirect fixtures #5798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
approved these changes
Aug 28, 2019
Contributor
blueyed
left a comment
blueyed
left a comment
There was a problem hiding this comment.
LGTM, please squash and force-push then.
Contributor
Author
|
@blueyed done. |
nicoddemus
approved these changes
Aug 30, 2019
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks a ton @aklajnert! This was a very long standing issue, glad someone took the time to fix it. 😁
I took the liberty of improving the changelog a bit and write the test in a way that IMHO is easier to follow and debug if it breaks in the future. Let me know if you don't agree with the changes. 👍
Contributor
Author
|
Thanks @nicoddemus, indeed - your test is much more straightforward. I had a few approaches for writing the test for it - mostly to reproduce the bug, but your solution is better. |
Member
|
Cool! Merging then, thanks again! |
This was referenced Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #570