Serialize/deserialize chained exceptions #5787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring this in order to support chained exceptions more easily. Related to pytest-dev#5786
Using a relative import like before was not very nice
nicoddemus
force-pushed
the
chained-exceptions-serializable-5786
branch
from
499c20a to
a511b98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes serialization/deserialization of report objects, which fixes it for
pytest-xdist(where #5786 originated).Moved the contents of
BaseReport._to_json/_from_jsonto free functions as they were getting quite large. More importantly, I refactored the code so it can be reused for chained exceptions.Move
TWMockclass to a fixture so it can be more easily reused in other test modules.test_codewas importing it using a relative import, which is not very nice.Fix #5786
cc @oliveira-esss @prusse-martin