Use TRAVIS_REPO_SLUG instead of hard-coding pytest-dev/pytest #5740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## features #5740 +/- ##
============================================
- Coverage 96.25% 96.23% -0.03%
============================================
Files 117 117
Lines 25902 25902
Branches 2495 2495
============================================
- Hits 24932 24926 -6
- Misses 666 672 +6
Partials 304 304
Continue to review full report at Codecov.
|
blueyed
approved these changes
Aug 14, 2019
I was doing final tests on the script today, and forgot to change the hardecoded "pytest-dev/pytest", which ended up publishing a `4.99.10` release to the main repository by mistake, as my token has access to both my fork and main repository. I deleted the tag immeditely just a few seconds later, so hopefully this won't cause major problems. This change makes it safer to test this in the future, never publishing to the main repository by mistake (as long as the tags are pushed to the right repositories of course).
nicoddemus
force-pushed
the
use-repo-env-var
branch
from
4b1ee95 to
cb94fd3
Compare
blueyed
approved these changes
Aug 14, 2019
nicoddemus
added a commit
to nicoddemus/pytest
that referenced
this pull request
Aug 19, 2019
Use TRAVIS_REPO_SLUG instead of hard-coding pytest-dev/pytest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was doing final tests on the script today, and forgot to change
the hardecoded "pytest-dev/pytest", which ended up publishing a
4.99.10release to the main repository by mistake, as my tokenhas access to both my fork and main repository. 🤕
I deleted the tag immeditely just a few seconds later, so hopefully
this won't cause major problems.
This change makes it safer to test this in the future, never publishing
to the main repository by mistake (as long as the tags are pushed to the
right repositories of course).